Skip to content

Commit

Permalink
Drop support for PHP 7.3 (#72)
Browse files Browse the repository at this point in the history
  • Loading branch information
mondrake authored Dec 11, 2023
1 parent 0795b7d commit 6abfc0c
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/code-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.3"
- "7.4"

steps:
- name: "Checkout code"
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/php-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,11 @@ jobs:
fail-fast: false
matrix:
php-version:
- "7.3"
- "7.4"
- "8.0"
- "8.1"
- "8.2"
- "8.3"
- "8.4"

steps:

Expand All @@ -48,7 +46,7 @@ jobs:
files: coverage.xml

- name: Mapping test
if: ${{ matrix.php-version == 7.4 }}
if: ${{ matrix.php-version == 8.1 }}
continue-on-error: true
run: |
php ./bin/fileeye-mimemap --version
Expand Down
8 changes: 4 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,20 @@
"homepage": "https://github.com/FileEye/MimeMap",
"license": "LGPL-3.0-or-later",
"require": {
"php": ">=7.3"
"php": ">=7.4"
},
"require-dev": {
"composer-runtime-api": "^2.0.0",
"phpunit/phpunit": "^9 | ^10",
"squizlabs/php_codesniffer": ">=3.6",
"squizlabs/php_codesniffer": ">=3.7",
"sebastian/comparator": ">=4",
"sebastian/diff": ">=4",
"symfony/filesystem": ">=5.4",
"symfony/console": ">=5.4",
"symfony/var-dumper": ">=5.4",
"symfony/yaml": ">=5.4",
"phpstan/phpstan": "^1.2",
"vimeo/psalm": "^4.23 | ^5"
"phpstan/phpstan": "^1.10",
"vimeo/psalm": "^5.15"
},
"autoload": {
"psr-4": {
Expand Down
3 changes: 1 addition & 2 deletions src/TypeParser.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ public static function parse(string $type_string, Type $type): void
$sub = static::parseStringPart($type_string, $sub['end_offset'] + 1, ';');
$tmp = explode('=', $sub['string'], 2);
$p_name = trim($tmp[0]);
$p_val = trim($tmp[1]);
$p_val = str_replace('\\"', '"', $p_val);
$p_val = str_replace('\\"', '"', trim($tmp[1] ?? ''));
$type->addParameter($p_name, $p_val, $sub['comment']);
}
}
Expand Down

0 comments on commit 6abfc0c

Please sign in to comment.