-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide means for accessing reference count without actually fetching the entities #650
Comments
This feature request partially opens up a path to a larger extension of the reference fetching enhancements. It would be also beneficial to be able to fetch only chunks of references. After discussion with @lukashornych we'd like to:
In order to do so, this language extension makes sense to us:
We still need to analyze how this proposal affects the internal structure of |
This issue will focus solely on referenced content. Pagination support in facet summary was moved to separate issue: #812 |
…tching the entities Extended parser, QueryConstraints and the constraint itself to accommodate paging child and its serialization. Refs: #650
…tching the entities Test fix. Refs: #650
Server side implementation except API integration done. @lukashornych please see usage patterns in tests:
Client (gRPC/Java) will follow next. |
…tching the entities Server side implementation done with tests. Refs: #650
…tching the entities Server side implementation done with tests. Refs: #650
…tching the entities Client side implementation done with tests. Refs: #650
…tching the entities Fix for providing total count only. Refs: #650
…ching the entities Added documentation (so far not tested). Refs: #650
…tching the entities Fixed problem when there are multiple entities in the result with slicing that needs to respect individual references of particular entities. Reference fetching was also optimized to avoid unnecessary bitmap unwrapping and rewrapping. Refs: #650
…tching the entities Parser fix. Refs: #650
…tching the entities Documentation. Refs: #650
Fixed problem and added tests that verify that it's possible to exchange chunks during entity enrichment. Refs: #650
When entity is enriched and doesn't redefine locales, it should inherit original locale. Refs: #650
|
@novoj Shouldn't the |
Why do you think so? When pageSize is zero, how many pages would you have for 17 records? Infinite. But we cannot pass infinite value, so better is zero or |
Yeah, you are right, that does make sense. I was coming from the |
@novoj GQL and REST API are completely done (API logic, int. tests, user docs). But I think you will need to implement some printing logic for |
Spacing support finalized, however there are still some tests failing. |
Still some tests are not passing. Corrected issue with duplicated groups in array during sorting and swapped arguments in OffsetAndLimit that led to invalid last page number. Refs: #650
…tching the entities Optimization. Refs: #650
…ying label headers, missing CORS headers BREAKING-CHANGE: REST API no longer support HTTP header `X-EvitaDB-Query-Label` for specifying query headers. Instead use `X-EvitaDB-Label`. Refs: #650
@novoj All tests seems to be working now. |
After recent discussion with FE team using evitaDB, there may be use case were we want to fetch entity that has existing referenced entities of some type. On top of that however, we want to fetch count of these referenced entities without actually fetching the entities.
Something like that:
I think it could be solved also with facet summary, probably like this:
But that's quite cumbersome to use on FE. @novoj do you think it would be valid to support the first approach at the GraphQL API level? We could also reuse the
filterBy
clause from the reference fields. On the backend it could be translated to basicreferenceContent
.I think we could automatically provide the count attribute on
EntityDecorator
level. evitaDB internally always needs to compute reference primary keys to calculate the count, so we could always provide the array of these primary keys (since they have to be fetched anyway). But on the API level the primary keys can easily be thrown away and only the count could be provided to the external clients, thus saving some transport/networking costs.The text was updated successfully, but these errors were encountered: