RedundantIfForBooleanCheck makes invalid suggestion

[Luro02]

Summary

The two expressions are equivalent, except for the case where ìsSafe = true, isEdgeLegal = true, isEdgeSafe = false.

Lint Name

RedundantIfForBooleanCheck

Reproducer

public static boolean edgeCondition(boolean isSafe, boolean isEdgeLegal, boolean isEdgeSafe) {
    if (isSafe) {
        return isEdgeLegal && isEdgeSafe;
    }

    return isEdgeLegal;
}

Given the above code, it suggests:

return isSafe && (isEdgeLegal && isEdgeSafe) || isEdgeLegal;

This is wrong.

The assumption is that the boolean isSafe is false when the || isEdgeLegal is evaluated. This is not the case, therefore an !isSafe && must be added to the suggestion:

return isSafe && (isEdgeLegal && isEdgeSafe) || !isSafe && isEdgeLegal;