Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service file assumes $DESTDIR=="/usr" #21

Open
patrislav1 opened this issue Mar 14, 2024 · 0 comments
Open

service file assumes $DESTDIR=="/usr" #21

patrislav1 opened this issue Mar 14, 2024 · 0 comments

Comments

@patrislav1
Copy link
Contributor

in media-automount@.service there's a hardcoded reference to /usr/bin/media-automount.

Makefile however installs the script to $(DESTDIR)$(PREFIX)/bin/media-automount.

On my system, both DESTDIR and PREFIX are empty, so the script is never called.

Suggestion: either leave away the $(DESTDIR)$(PREFIX) in the Makefile and hard code the prefix to /usr, or configure the service file at build time.

I would do a PR however am not that seasoned in Makefile builds, what's the best practice to achieve this? maybe insert something like @DESTDIR@ in the service file and replace it with sed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant