Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MATS Gym to 3rd party env list. #1152

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

axelbr
Copy link
Contributor

@axelbr axelbr commented Jan 8, 2024

Description

Added MATS Gym to the 3rd party environment list.

Type of change

  • Documentation

Screenshots

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower
Copy link
Contributor

Cool stuff, thanks for the contribution. Good choice putting it next to the other CARLA Gym project. May be worth mentioning it explicitly in comparison to that, if you want. It looks like the other repo hasn't been updated in 8 months and is a fork of an old gym repo, if you check it and see that it doesn't work or something like that I could remove it. Generally I'd like to have at least semi-maintained projects on that page, not just someone's fork that they made and abandoned.

@axelbr
Copy link
Contributor Author

axelbr commented Jan 9, 2024

Thanks! I will check it out and let you know.

@axelbr
Copy link
Contributor Author

axelbr commented Jan 10, 2024

It worked when I tried it with newer versions of CARLA.

@elliottower elliottower merged commit aa65027 into Farama-Foundation:master Jan 11, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants