Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract all auto code into Auto.java #22

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

rechsby
Copy link
Contributor

@rechsby rechsby commented Dec 17, 2024

Moves all Auto code to an Auto.java file. Resolves #21

Moved:

  • AutoBuilder setup
  • LoggedDashboardChooser

Centralizes all autonomous code and declutters RobotContainer in the process.

Added another Choreo test path to test path following as well.

@rechsby
Copy link
Contributor Author

rechsby commented Dec 17, 2024

@Sloghead11 's trajectory logging (#20 ) would have to be moved into Auto.java, my guess would be within the constructor which is where the autoChooser is registered.

Copy link
Member

@mmilunicmobile mmilunicmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a solid choice to move it! I merged in the changes from main.

@mmilunicmobile
Copy link
Member

Yo sorry for the squash, for some reason the rebase wasnt working

@mmilunicmobile mmilunicmobile merged commit 93c1761 into main Dec 17, 2024
2 checks passed
@mmilunicmobile mmilunicmobile deleted the auto-structure-rework branch December 17, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move auto code to a separate file to clean up RobotContainer
2 participants