Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Choreo Settings & Test Path #17

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Added Choreo Settings & Test Path #17

merged 2 commits into from
Dec 16, 2024

Conversation

rechsby
Copy link
Contributor

@rechsby rechsby commented Dec 14, 2024

Added Choreo settings from Pathplanner values.

Tested in simulation, extremely accurate path following.

mmilunicmobile
mmilunicmobile approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@mmilunicmobile mmilunicmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These overall look like some good changes and exactly what we needed.

@mmilunicmobile mmilunicmobile merged commit 00bc4da into main Dec 16, 2024
2 checks passed
@mmilunicmobile mmilunicmobile deleted the choreo-interop branch December 16, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilunicmobile mmilunicmobile mmilunicmobile approved these changes

@sjsonline sjsonline Awaiting requested review from sjsonline sjsonline is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rechsby @mmilunicmobile