Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a Simulation with Maple-Sim #16

Open
mmilunicmobile opened this issue Dec 13, 2024 · 3 comments
Open

Make a Simulation with Maple-Sim #16

mmilunicmobile opened this issue Dec 13, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mmilunicmobile
Copy link
Member

No description provided.

@mmilunicmobile
Copy link
Member Author

This is basically a different approach for maple sim that instead of running the sim separately or in a different interface, just doesn't call sim drivetrain update

@mmilunicmobile mmilunicmobile linked a pull request Dec 16, 2024 that will close this issue
@mmilunicmobile mmilunicmobile self-assigned this Dec 22, 2024
@mmilunicmobile mmilunicmobile changed the title try making an injected simulation Make a Simulation with Maple-Sim Dec 22, 2024
@mmilunicmobile
Copy link
Member Author

Basically just for extra clarity, this is what that entails:

Use Maple-Sim as a layer on top of the base CTRE motor controllers. The sim motor classes should be used to get all information about how the motor will behave.

You should be able to treat the drivetrain completely normally basically.

Should also be able to be toggled on or off. (Probably off by default.)

@mmilunicmobile mmilunicmobile added the wontfix This will not be worked on label Jan 13, 2025
@mmilunicmobile mmilunicmobile closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2025
@mmilunicmobile
Copy link
Member Author

After a lot of work it looks like they updated maple-sim to actually properly work with CTRE.

https://github.com/Shenzhen-Robotics-Alliance/maple-sim/tree/main/templates/CTRE%20Swerve%20with%20maple-sim

This should be added as an option on top of normal sim that is disabled by default.

@mmilunicmobile mmilunicmobile added enhancement New feature or request and removed wontfix This will not be worked on labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant