Skip to content

Simple FACMAC Observations only include last Other Agents velocity? #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Advertise-Here opened this issue Mar 4, 2025 · 0 comments
Assignees

Comments

@Advertise-Here
Copy link

Good morning

In running the Simple FACMAC environment it appears observations comprise :

  • own velocity: x, y
  • own position: x,y
  • landmark positions: x,y for each (if any)
  • other agent relative positions: x,y for each
  • other agent velocities: x,y

Currently it appears the other agent velocities only include the final other agent due to the slice [-1:] in 'simple_facmac.py':

def _good(aidx):
    return jnp.concatenate(
        [
            state.p_vel[aidx].flatten(),  # 2
            state.p_pos[aidx].flatten(),  # 2
            landmark_pos[aidx].flatten(),  # 5, 2
            other_pos[aidx].flatten(),  # 5, 2
            jnp.zeros_like(other_vel[aidx, -1:].flatten())  # SLICE IS HERE
        ]
    )

def _adversary(aidx):
    return jnp.concatenate(
        [
            state.p_vel[aidx].flatten(),  # 2
            state.p_pos[aidx].flatten(),  # 2
            landmark_pos[aidx].flatten(),  # 5, 2
            other_pos[aidx].flatten(),  # 5, 2
            other_vel[aidx, -1:].flatten(),  # SLICE IS HERE
        ]
    )

Have I interpreted this correctly? Or should all the other agent velocities be included in the observation to pair-up with their positions (which appears so I think in the original FACMAC paper code)?

thank you

@amacrutherford amacrutherford self-assigned this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants