Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new element resourceProfile #267

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Add new element resourceProfile #267

merged 1 commit into from
Nov 7, 2024

Conversation

johngrimes
Copy link
Collaborator

@johngrimes johngrimes commented Nov 5, 2024

This element communicates that the view definition was intended to be executed against the supplied set of profiles.

Resolves #265.

This element communicates that the view definition was intended to be
executed against the supplied set of profiles.
@johngrimes johngrimes merged commit 1edbeaa into master Nov 7, 2024
1 check passed
@niquola
Copy link
Member

niquola commented Nov 8, 2024

Why not just VD.profile?

@johngrimes
Copy link
Collaborator Author

Why not just VD.profile?

I think this is a good suggestion (it's shorter!), and looking through the FHIR spec I can see a number of other references to StructureDefinition canonicals that are called profile.

If @rbrush agrees, I will update this and save us some bytes!

@grahamegrieve
Copy link
Contributor

The question is what is the profile about. Just 'profile' is slightly more ambiguous than 'resourceProfile' but only very slightly. 'requiredProfile' would be more explicit but I'm not a fan of it being longer. 'profile' is probably OK as long as the shortDoco is crisp and explains exactly what it does

@johngrimes
Copy link
Collaborator Author

This is what I came up with for the short and long doco:

FHIR profiles that this view definition was intended to be executed against

Indicates that this view definition was intended to be executed against any of the specified FHIR profiles.

@grahamegrieve
Copy link
Contributor

What that doesn't say is that it's the resources that are being 'viewed' that the profile applies to - and it's important to be explicit, I think, since multiple different things can be profiled

@johngrimes
Copy link
Collaborator Author

Agreed, here is an update:

FHIR profiles that this view definition was intended to be executed against

Indicates that this definition was designed to create a view over a set of resources conforming to the specified FHIR profiles. Each of these profiles SHALL be based upon the resource type specified in resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewDefs "nominate" profile application
4 participants