Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint conflict between instance, registry and baremetal #4

Open
korridor opened this issue Jul 22, 2021 · 5 comments
Open

Endpoint conflict between instance, registry and baremetal #4

korridor opened this issue Jul 22, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@korridor
Copy link

Endpoints like ListServers or ListImages are in multiple namespaces and there functions are overwriting each other.

@korridor korridor changed the title Endpoint conflict between instance and baremetal Endpoint conflict between instance, registry and baremetal Jul 22, 2021
@FGRibreau
Copy link
Owner

Happy to accept a PR for it! 👍

@FGRibreau FGRibreau added the enhancement New feature or request label Jul 23, 2021
@mcoolive
Copy link

Hi,

I can work on a PR. But I have a question on the design. Should we simply rename some functions ? Or should we rework the actual SCW-Client and cut it into several APIs ? The first option is simpler to implement. The second option is a big breaking change.

More detail about how I think to divide the actual client:

  • a smaller client that just hold the common axis config (see ticket Use axios global config #1)
  • API objects that wrap the client and provide functions limited to: instances, baremetal, etc.
  • this would presents a naming similar to what is achieved by Scaleway-sdk-go

@FGRibreau
Copy link
Owner

Hello @mcoolive :)
I would go with option two, we will release another major version but it will be way simpler for users, I should have made it that way on the first iteration, sorry ^^'

@mcoolive
Copy link

So, should I wait? Or are you interesting by a PR ?

@FGRibreau
Copy link
Owner

FGRibreau commented Oct 20, 2021

Interested by a PR yes for reworking the client into multiple sub-clients (one for each functions (instances, baremetal, ...)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants