feat: warn players when XACT-errors are in their logs #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheikah45
requested changes
Dec 30, 2024
src/main/java/com/faforever/client/logging/analysis/AnalysisResult.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/logging/analysis/LogAnalyzerService.java
Outdated
Show resolved
Hide resolved
* Fixed comments
Sheikah45
reviewed
Jan 6, 2025
src/main/java/com/faforever/client/logging/analysis/AnalysisResult.java
Outdated
Show resolved
Hide resolved
Ivan-Shaml
force-pushed
the
feat/xact-error-warning
branch
from
36c4f41 to
553992a
Compare
Sheikah45
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for
info: Minimized trueandXACTlog entries in the latest game log.If present -> a message is displayed, when the game exits (only on exitCode !=0)
Closes #3142