add dataSet actions in project page #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiquelAdell
approved these changes
Dec 12, 2024
…ea/dataset-configuration into feature/dataset-actions
Done @MiquelAdell |
tokland
approved these changes
Dec 12, 2024
| @@ -0,0 +1,88 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
[global] after a "yarn localize" I see changes for the i18n files.
| ) | ||
| ); | ||
|
|
||
| return <ObjectsTable {...tableConfig} />; | ||
| const reloadProjects = React.useCallback((isCancelAction: boolean) => { |
There was a problem hiding this comment.
minor, no need to change it, but as a general rule, naked boolean arguments are not declarative when used: reloadProjects(false). Instead: reloadProjects({ isCancelAction: false })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
🔥 Notes to the tester
#8696rgk6z