feat: pass options to secp256k1 signBuffer #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mvayngrib
reviewed
Feb 28, 2024
kewde
previously approved these changes
Feb 29, 2024
|
Anything else here? |
maksim-iv-exodus
approved these changes
Feb 29, 2024
mvayngrib
approved these changes
Mar 1, 2024
|
@feri42 merged, but the multi-seed keychain is still being integrated all over the place. Do you want this also backported to the single-seed keychain for now? |
|
@mvayngrib , yes definitely. Where is the single-seed keychain located? I need to import this into the platforms to finish the whole POC. |
in a commit from ages long bygone |
|
@feri42 it's keychain 5.x, i'll see if i can create a branch and release from there |
|
Mobile has keychain 4.x. Seeing this is 5.x, will it be a reasonable effort to bump keychain there? |
|
shouldn't be, @sparten11740 can u grab bumping keychain on mobile? |
mvayngrib
pushed a commit
that referenced
this pull request
Mar 1, 2024
mvayngrib
added a commit
that referenced
this pull request
Mar 1, 2024
|
backported + released to |
r4vn
pushed a commit
that referenced
this pull request
Apr 2, 2024
r4vn
added a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For signing ETH transactions we need to pass the
canonicaloption toec.sign. Also, using the DER format of the signature can be quite challenging as there is no simple function to pick it apart. With this change we can get the raw signature. It would be better ifsignBufferdidn't return the DER encoded value at all.Fixtures for the new test were created using the ethereumjs library.