Fixed user comparison for AlbumController:checkAlbumOwning method

Exercise · Nov 18, 2014 · 0b5e294 · 0b5e294
1 parent 1f8715b
commit 0b5e294
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Controller/AlbumController.php b/Controller/AlbumController.php
@@ -131,9 +131,15 @@ protected function getAlbumUrl(AlbumInterface $album)
         return $this->container->get('foq_album.url_generator')->getAlbumUrl('foq_album_album_show', $album);
     }
 
+    /**
+     * @param AlbumInterface $album
+     * @throws AccessDeniedException
+     * @return void
+     */
     protected function checkAlbumOwning(AlbumInterface $album)
     {
-        if ($album->getUser() !== $this->container->get('foq_album.security_helper')->getUser()) {
+        if (!$this->container->get('foq_album.security_helper') ||
+            $album->getUser()->getId() !== $this->container->get('foq_album.security_helper')->getUser()->getId()) {
             throw new AccessDeniedException();
         }
     }

diff --git a/SecurityHelper.php b/SecurityHelper.php
@@ -14,6 +14,9 @@ public function __construct(SecurityContext $securityContext)
         $this->securityContext = $securityContext;
     }
 
+    /**
+     * @return void|User
+     */
     public function getUser()
     {
         if ($token = $this->securityContext->getToken()) {