Underwater terrain-aware wave forcing

[mbkuhn]

Summary

Turn off wave forcing where there is terrain, and modify ocean wave boundary to also be aware.

Pull request type

Please check the type of change introduced:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Checklist

The following is included:

• new unit-test(s)
• new regression test(s)
• documentation for new capability

This PR was tested by running:

• the unit tests
  • on GPU
  • on CPU
• the regression tests
  • on GPU
  • on CPU -- the ow_* and terrain tests, specifically

Additional background

For continuing collaboration with water power

[mbkuhn]

Once this gets a regression test, we can upgrade it to "ready for review".

[mbkuhn]

Main point of PR: allow terrain drag to do its thing underwater.

Wave forcing modifies velocity fields within the relaxation zones -- now it will leave cells untouched that are "blanked" (inside terrain) or marked as drag cells (velocity is modified by drag term).

Wave boundary fill sets the boundary velocity to the target velocity of the wave profile -- now it will set the velocity to 0 in boundary cells that are adjacent to "blanked" cells so no flow is pushing directly into terrain at the boundary.

[mbkuhn]

From reg test after 10 steps. Enlarged the wave to be able to see it. In application, test would typically be run with some mesh refinements.

[marchdf]

Cool work!

[hgopalan]

We should consider adding a walk through using Will's case. This PR adds many different capabilities in a single solve.

[mbkuhn]

We should consider adding a walk through using Will's case. This PR adds many different capabilities in a single solve.

That's a good idea! I'm getting the capability in for the version release, but I think there will be more development and documentation as Matt and Will continue to look into this.

[moprak-nrel]

Cool work! Have just a super minor comment