Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: ahp granting #415

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TiBarification
Copy link

@TiBarification TiBarification commented Jan 26, 2025

Description

Describe the changes

What is the current behavior? function does not return instance of class

What is the new behavior? now returns

Does this PR introduce a breaking change? no

Other information:
Why we have this method without actually getting instance. For example I need to remove particular Ahp process in a future, now I have a reference of it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions bot added the API label Jan 26, 2025
@TiBarification TiBarification changed the title Feature/ahp refactor ahp granting Jan 26, 2025
@TiBarification TiBarification changed the title refactor ahp granting refactor: ahp granting Jan 26, 2025
@louis1706 louis1706 changed the title refactor: ahp granting refactor!: ahp granting Jan 26, 2025
@TiBarification
Copy link
Author

disagree with tag "breaking changes". What breaking? You can keep using it like "void" function if not needed result.

@louis1706
Copy link

Modifying return type does breaking change
plugin build with a previous version will return an error if we do merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants