feat!: Rename "TextInputSetting" to "TextAreaSetting" and added TextInputSetting #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More features for the Light wrapper
I did NOT wanna make a PR today
Trevlouw
changed the title
|
I forgor to add feat 😩 |
Trevlouw
changed the title
is it possible than you make a pr that add the feature without breaking change (so different naming) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
valera named the wrapper for the SSTextArea setting "TextInputSetting" even though this setting only displays text from the server (you can't input text into it) so when I wanted to make something for a text area I asked on the discord, got told to make a PR for the SSPlaintextSetting so I spent like 30m trying to do so and eventually succeeding, the problem is, I wanted to use a SSTextArea the entire time but valera named it wrong 😭 😭 😭 😭 so I spent 30m trying to make something that nobody asked for when what I wanted already existed. So, because I made the actual TextInputSetting and the previous TextInputSetting should've been renamed to TextAreaSetting, I made this PR where the TextInputSetting is an actual text input and added the TextAreaSetting which is a text area.
What is the current behavior? (You can also link to an open issue here)
TextInputSetting class name is misleading, there is no SSS for an actual text input
What is the new behavior? (if this is a feature change)
TextInputSetting now represents the setting where you can input a string, there is now TextAreaSetting which replaces the old TextInputSetting's role
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes, I renamed the TextInputSetting so devs just need to change there code from new TextInputSetting(args) to TextAreaSetting(args)
Other information:
I am REALLY bad at this so please proofread what I did 🙏
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other