Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Scp914.PickupsInBooth & Scp914.PlayersInBooth #381

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

NotZer0Two
Copy link

Description

Describe the changes
Adding a simpler way to get players and pickups on the booth

What is the current behavior? (You can also link to an open issue here)
none.

What is the new behavior? (if this is a feature change)
just the same as before but easier

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Other information:
Requested by Lumi.


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@ITeMbI4
Copy link

ITeMbI4 commented Jan 6, 2025

Is it possible to add check for output booth?

@NotZer0Two
Copy link
Author

Is it possible to add check for output booth?

For that you can use the method and + it cannot be managed to add both of them

@louis1706
Copy link

Why not just using Scp914InputObject ? I mean this property are kinda useless

@louis1706
Copy link

A plugin can easily do that him self also it's not really optimised since it's will anyway still load the one you don't need

@louis1706 louis1706 changed the base branch from xmas-2024 to dev January 16, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants