Deprecate unused protobuf messages (#372)

* Deprecate unused protobuf messages
EventStore · May 7, 2024 · 5d11c69 · 5d11c69
1 parent 8b31a01
commit 5d11c69
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 18 deletions.
diff --git a/protos/persistent.proto b/protos/persistent.proto
@@ -98,15 +98,16 @@ message CreateReq {
 
 	message Options {
 		oneof stream_option {
-			StreamOptions stream = 4;
+			StreamOptions stream = 4 [deprecated = true];
 			AllOptions all = 5;
 		}
-		event_store.client.StreamIdentifier stream_identifier = 1 [deprecated=true];
+		event_store.client.StreamIdentifier stream_identifier = 1;
 		string group_name = 2;
 		Settings settings = 3;
 	}
 
 	message StreamOptions {
+    option deprecated = true;
 		event_store.client.StreamIdentifier stream_identifier = 1;
 		oneof revision_option {
 			uint64 revision = 2 [jstype = JS_STRING];
@@ -161,11 +162,11 @@ message CreateReq {
 		int32 history_buffer_size = 12;
 		ConsumerStrategy named_consumer_strategy = 13 [deprecated = true];
 		oneof message_timeout {
-			int64 message_timeout_ticks = 4 [jstype = JS_STRING];
+			int64 message_timeout_ticks = 4 [jstype = JS_STRING, deprecated = true];
 			int32 message_timeout_ms = 14;
 		}
 		oneof checkpoint_after {
-			int64 checkpoint_after_ticks = 6 [jstype = JS_STRING];
+			int64 checkpoint_after_ticks = 6 [jstype = JS_STRING, deprecated = true];
 			int32 checkpoint_after_ms = 15;
 		}
 		string consumer_strategy = 16;
@@ -186,7 +187,7 @@ message UpdateReq {
 
 	message Options {
 		oneof stream_option {
-			StreamOptions stream = 4;
+			StreamOptions stream = 4 [deprecated = true];
 			AllOptions all = 5;
 		}
 		event_store.client.StreamIdentifier stream_identifier = 1 [deprecated = true];
@@ -229,11 +230,11 @@ message UpdateReq {
 		int32 history_buffer_size = 12;
 		ConsumerStrategy named_consumer_strategy = 13;
 		oneof message_timeout {
-			int64 message_timeout_ticks = 4 [jstype = JS_STRING];
+			int64 message_timeout_ticks = 4 [jstype = JS_STRING, deprecated = true];
 			int32 message_timeout_ms = 14;
 		}
 		oneof checkpoint_after {
-			int64 checkpoint_after_ticks = 6 [jstype = JS_STRING];
+			int64 checkpoint_after_ticks = 6 [jstype = JS_STRING, deprecated = true];
 			int32 checkpoint_after_ms = 15;
 		}
 	}

diff --git a/protos/projections.proto b/protos/projections.proto
@@ -24,12 +24,13 @@ message CreateReq {
 	message Options {
 		oneof mode {
 			event_store.client.Empty one_time = 1;
-			Transient transient = 2;
+			Transient transient = 2 [deprecated = true];
 			Continuous continuous = 3;
 		}
 		string query = 4;
 
 		message Transient {
+      option deprecated = true;
 			string name = 1;
 		}
 		message Continuous {
@@ -79,7 +80,7 @@ message StatisticsReq {
 		oneof mode {
 			string name = 1;
 			event_store.client.Empty all = 2;
-			event_store.client.Empty transient = 3;
+			event_store.client.Empty transient = 3 [deprecated = true];
 			event_store.client.Empty continuous = 4;
 			event_store.client.Empty one_time = 5;
 		}

diff --git a/protos/shared.proto b/protos/shared.proto
@@ -23,6 +23,7 @@ message StreamIdentifier {
 }
 
 message AllStreamPosition {
+  option deprecated = true;
 	uint64 commit_position = 1 [jstype = JS_STRING];
 	uint64 prepare_position = 2 [jstype = JS_STRING];
 }
@@ -57,5 +58,6 @@ message MaximumAppendSizeExceeded {
 }
 
 message BadRequest {
+  option deprecated = true;
 	string message = 1;
 }
diff --git a/protos/streams.proto b/protos/streams.proto
@@ -34,7 +34,7 @@ message ReadReq {
 			event_store.client.Empty no_filter = 8;
 		}
 		UUIDOption uuid_option = 9;
-		ControlOption control_option = 10;
+		ControlOption control_option = 10 [deprecated = true];
 
 		enum ReadDirection {
 			Forwards = 0;
@@ -84,6 +84,8 @@ message ReadReq {
 			}
 		}
 		message ControlOption {
+      option deprecated = true;
+
 			uint32 compatibility = 1;
 		}
 	}
@@ -95,9 +97,9 @@ message ReadResp {
 		SubscriptionConfirmation confirmation = 2;
 		Checkpoint checkpoint = 3;
 		StreamNotFound stream_not_found = 4;
-		uint64 first_stream_position = 5 [jstype = JS_STRING];
-		uint64 last_stream_position = 6 [jstype = JS_STRING];
-		AllStreamPosition last_all_stream_position = 7;
+		uint64 first_stream_position = 5 [jstype = JS_STRING, deprecated = true];
+		uint64 last_stream_position = 6 [jstype = JS_STRING, deprecated = true];
+		AllStreamPosition last_all_stream_position = 7 [deprecated = true];
 		CaughtUp caught_up = 8;
     FellBehind fell_behind = 9;
 	}
@@ -184,13 +186,13 @@ message AppendResp {
 
 	message WrongExpectedVersion {
 		oneof current_revision_option_20_6_0 {
-			uint64 current_revision_20_6_0 = 1;
-			event_store.client.Empty no_stream_20_6_0 = 2;
+			uint64 current_revision_20_6_0 = 1 [deprecated = true];
+			event_store.client.Empty no_stream_20_6_0 = 2 [deprecated = true];
 		}
 		oneof expected_revision_option_20_6_0 {
-			uint64 expected_revision_20_6_0 = 3;
-			event_store.client.Empty any_20_6_0 = 4;
-			event_store.client.Empty stream_exists_20_6_0 = 5;
+			uint64 expected_revision_20_6_0 = 3 [deprecated = true];
+			event_store.client.Empty any_20_6_0 = 4 [deprecated = true];
+			event_store.client.Empty stream_exists_20_6_0 = 5 [deprecated = true];
 		}
 		oneof current_revision_option {
 			uint64 current_revision = 6 [jstype = JS_STRING];