Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CfP closed – update website #992

Merged
merged 4 commits into from
Feb 4, 2025
Merged

CfP closed – update website #992

merged 4 commits into from
Feb 4, 2025

Conversation

rodrigogiraoserrao
Copy link
Contributor

I used a bit of common sense and my judgment to figure out what needed to be changed but I might be wrong here, so please check my changes ;)

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Preview available

Key Value
url https://cfp-close.ep-preview.click
last update 2025-02-04T10:55:20.190Z

@rodrigogiraoserrao
Copy link
Contributor Author

Most notably, there is a card in the centre of the main page that talks about the CfP but I don't know what to replace it with 🤷.

src/components/header/header-actions.astro Outdated Show resolved Hide resolved
Comment on lines 16 to 20
<li>**3 February 2025:** Call for Proposals (CfP) closes (<b>Extension</b>)</li>
</ul>

<ul className="milestone-todo">
<li><strike>**27 January 2025:** Call for Proposals (CfP) closes</strike></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>**3 February 2025:** Call for Proposals (CfP) closes (<b>Extension</b>)</li>
</ul>
<ul className="milestone-todo">
<li><strike>**27 January 2025:** Call for Proposals (CfP) closes</strike></li>
<li>**27 January 2025:** Call for Proposals (CfP) closes</li>
<li>**3 February 2025:** Extension of Call for Proposals (CfP) closes</li>
</ul>
<ul className="milestone-todo">

Or remove the extension part completely and pretend that we only had this later date.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to keep info about the fact that the CFP was extended. See the new version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you removed the initial closing date for the cfp on purpose now? - Just checking. Not objecting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, because the CfP didn't close on the 27th. Only on the 3rd (after an extension).

src/content/pages/faq.mdx Outdated Show resolved Hide resolved
src/content/pages/programme/cfp.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@cybit cybit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just the one thing with double checking if the first cfp end-date was removed on purpose. Rest looks good to me.

@rodrigogiraoserrao rodrigogiraoserrao merged commit 1e2ef8f into ep2025 Feb 4, 2025
4 checks passed
@rodrigogiraoserrao rodrigogiraoserrao deleted the cfp-close branch February 4, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants