Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.1 support #93

Merged
merged 17 commits into from
Nov 20, 2024
Merged

7.1 support #93

merged 17 commits into from
Nov 20, 2024

Conversation

Minmoose
Copy link
Member

No description provided.

@Minmoose Minmoose self-assigned this Nov 15, 2024
- Items in `Hair` & `Face Paint` selectors are incorrect
@Minmoose
Copy link
Member Author

Current known issues are,

  • The when choosing hair or face paint the items presented are incorrect
  • The shader properties section on the Advanced Appearance Window do not show, I believe this is because the offset values for the shader values have changed
  • Animation speed control and freeze character animation buttons are broken

@Cellane
Copy link

Cellane commented Nov 20, 2024

I'm sorry to butt in on a work-in-progress PR, but I tested it the other day (I believe latest commit as of time of writing this comment) and found another issue, in which the modal window for selecting animation/emote doesn't show nearly as many emotes as pre-7.1, emotes such as ranger poses, ball dance, push-ups and more are missing entirely, and a lot of other emotes only have the Intro animation listed, not their Loop animation – such as Bee's Knees.

(I think I also couldn't easily find unnamed poses such as chairsit/groundsit/bed but I think I didn't search thoroughly enough for them.)

@Minmoose
Copy link
Member Author

@Cellane Don't worry you're not "butting" in, I appreciate the report as I didn't catch that, I'll investigate, Thanks!

Minmoose and others added 6 commits November 20, 2024 08:55
`ActionTimeline.Slot` return is now different from what it was before, might be a Lumina bug and this may need to be reverted in the future
@Minmoose Minmoose marked this pull request as ready for review November 20, 2024 22:25
@Minmoose Minmoose merged commit 29bc5c3 into main Nov 20, 2024
2 checks passed
@Minmoose Minmoose deleted the 7.1 branch November 20, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants