fix: brio camera not being added to _createdCameras
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work, thanks for the catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #129 regarding Brio 0.5.0 / 0.5.0.1 where the deletion of a "Brio Camera" fails to occur due to missing logic in the
CreateCameracode.I've found that the code for the camera only had the implementation for Free Camera which works 100% while Brio Camera logic was missing. Due to this, deleting a Brio Camera was more difficult to delete as you would have to instead fiddle with several buttons in Brio to get it to work or disable and re-enable Brio for a new layout.
This fix adds missing logic to Brio cameras on the
CreateCamerafunction to make the "Destroy" buttons work properly.