From 3134074be5efc55d9fbb7d99902f3724d8394b45 Mon Sep 17 00:00:00 2001 From: Azariel Del Carmen <40864681+Bronya-Rand@users.noreply.github.com> Date: Mon, 17 Feb 2025 16:17:29 -0600 Subject: [PATCH] fix: brio camera not being added to `_createdCameras` (#130) * fix: brio camera not being added to `_createdCameras` * Update VirtualCameraManager.cs --------- Co-authored-by: Kenneth M --- Brio/Game/Camera/VirtualCameraManager.cs | 31 +++++++++++++++++------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/Brio/Game/Camera/VirtualCameraManager.cs b/Brio/Game/Camera/VirtualCameraManager.cs index e473ab29..dc499e2c 100644 --- a/Brio/Game/Camera/VirtualCameraManager.cs +++ b/Brio/Game/Camera/VirtualCameraManager.cs @@ -55,16 +55,29 @@ public VirtualCameraManager(IServiceProvider serviceProvider, GPoseService gPose if(virtualCamera is null) { - if(cameraType == CameraType.Free) + switch(cameraType) { - camEnt.VirtualCamera.FreeCamValues.MovementSpeed = DefaultMovementSpeed; - camEnt.VirtualCamera.FreeCamValues.MouseSensitivity = DefaultMouseSensitivity; - camEnt.VirtualCamera.IsFreeCamera = true; - camEnt.VirtualCamera.ActivateCamera(); - camEnt.VirtualCamera.ToFreeCam(); - camEnt.VirtualCamera.DeactivateCamera(); - - _createdCameras.Add(_cameraId, camEnt); + case CameraType.Free: + camEnt.VirtualCamera.FreeCamValues.MovementSpeed = DefaultMovementSpeed; + camEnt.VirtualCamera.FreeCamValues.MouseSensitivity = DefaultMouseSensitivity; + camEnt.VirtualCamera.IsFreeCamera = true; + camEnt.VirtualCamera.ActivateCamera(); + camEnt.VirtualCamera.ToFreeCam(); + camEnt.VirtualCamera.DeactivateCamera(); + _createdCameras.Add(_cameraId, camEnt); + break; + case CameraType.Brio: + camEnt.VirtualCamera.IsFreeCamera = false; + camEnt.VirtualCamera.ActivateCamera(); + camEnt.VirtualCamera.DeactivateCamera(); + _createdCameras.Add(_cameraId, camEnt); + break; + //case CameraType.Cutscene: + // unimplemented + // break; + default: + Brio.Log.Error($"Unknown camera type: {cameraType}"); + break; } } else