extract polygon holes when converting initial shape geometry #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistafunk
force-pushed
the
shaegler/initial-shapes-with-holes
branch
2 times, most recently
from
8de5fc0 to
b999ced
Compare
mistafunk
force-pushed
the
shaegler/initial-shapes-with-holes
branch
from
b999ced to
b29a734
Compare
chr11115
requested changes
Apr 1, 2025
There was a problem hiding this comment.
Nice work!
I think we should generalize the code such that we can test it. There is also some room for improvement in naming/organization (some of it is opinionated and you can leave it if you feel strongly about some of the structure/names), but overall great stuff!
mistafunk
force-pushed
the
shaegler/initial-shapes-with-holes
branch
from
72d16e9 to
b26eb63
Compare
|
Addressed the review comments, please have another look :-) |
chr11115
approved these changes
Apr 22, 2025
mistafunk
force-pushed
the
shaegler/initial-shapes-with-holes
branch
4 times, most recently
from
a6fdc18 to
ca37604
Compare
mistafunk
force-pushed
the
shaegler/initial-shapes-with-holes
branch
from
ca37604 to
a4b179a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.