Breaks in Ember 3.25 (and perhaps earlier) apps

[tomwayson]

Somewhere between ember 3.16 and 3.25, something changed and it appears to cause the esri-loader script to be included in the files that we replace require() and define().

STR:

• create a new 3.25 app
• add ember-esri-loader
• call loadModules()

You'll get the following error:

Digging into that you see that it fails on this line in esri-loader.js:

which should be

var errorHandler = window['require'].on('error', reject);

I also notice that yarn test:all fails on the release and canary scenarios, so that may be related, but it also failed on the 2.x scenario, so 🤷 :

------ RESULTS ------

Scenario ember-lts-2.16: FAIL
Command run: ember test
with env: {
  "EMBER_OPTIONAL_FEATURES": "{\"jquery-integration\":true}"
}
Scenario ember-lts-2.18: SUCCESS
Command run: ember test
with env: {
  "EMBER_OPTIONAL_FEATURES": "{\"jquery-integration\":true}"
}
Scenario ember-release: SUCCESS
Command run: ember test
Scenario ember-beta: FAIL
Command run: ember test
Scenario ember-canary: FAIL
Command run: ember test
Scenario ember-default: SUCCESS
Command run: ember test
Scenario ember-default-with-jquery: SUCCESS
Command run: ember test
with env: {
  "EMBER_OPTIONAL_FEATURES": "{\"jquery-integration\":true}"
}

3 scenarios failed
4 scenarios succeeded
7 scenarios run