refactor(radio-button)!: remove deprecated guid property #10799
+3
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
11 tasks
jcfranco
approved these changes
Nov 20, 2024
jcfranco
added
the
skip visual snapshots
jcfranco
reviewed
Nov 20, 2024
| @@ -169,8 +168,6 @@ describe("calcite-radio-button", () => { | |||
| firstRadioButton.insertAdjacentHTML("beforebegin", newRadioButton); | |||
| }); | |||
|
|
|||
| await page.keyboard.press("Tab"); | |||
There was a problem hiding this comment.
These removals seem to be causing test failures. Can you restore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9713
Summary
BREAKING CHANGE: Removes the deprecated property
guidfromcalcite-radio-button.Developers may need to replace
calcite-radio-button'sguidproperty with a uniqueidproperty.