Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(block)!: add required label property and mark heading as optional #10739

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat(block)!: add required label property and mark heading as optional #10739

merged 1 commit into from
Nov 19, 2024

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Nov 15, 2024 •
edited
Loading

Related Issue: #8697

Summary

  • Adds label property as required to provide context for AT users.
  • heading is no longer a required property.

BREAKING CHANGE: The component's label property is a required property and heading is an optional property.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Nov 15, 2024
@anveshmekala anveshmekala marked this pull request as ready for review November 15, 2024 23:20
@anveshmekala anveshmekala added breaking change Issues and pull requests with code changes that are not backwards compatible. pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 15, 2024
driskull
driskull approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiice 😄

packages/calcite-components/src/components/block/block.tsx
@@ -378,7 +385,7 @@ export class Block

const headerNode = (
<div class={CSS.headerContainer}>
{this.dragHandle ? <calcite-handle label={heading} /> : null}
{this.dragHandle ? <calcite-handle label={heading || label} /> : null}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but maybe this should use the newer calcite-drag-handle at some point? Should we have an issue. @jcfranco

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #10382 should cover it 👍

@anveshmekala
Copy link
Contributor Author

Adding @geospatialem for Accessibility review.

@anveshmekala anveshmekala merged commit c252ce3 into dev Nov 19, 2024
18 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/8697-block-add-label-and-heading-optional branch November 19, 2024 19:11
alisonailea pushed a commit that referenced this pull request Nov 19, 2024
@anveshmekala @alisonailea
feat(block)!: add required label property and mark heading as optional (
86d4aaa 
#10739)

**Related Issue:** #8697 

## Summary

- Adds `label` property as required to provide context for AT users.
- `heading` is no longer a required property.


BREAKING CHANGE: The component's `label` property is a required property
and `heading` is an optional property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@jcfranco jcfranco jcfranco left review comments

Assignees

@anveshmekala anveshmekala

Labels
breaking change Issues and pull requests with code changes that are not backwards compatible. enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

Successfully merging this pull request may close these issues.
3 participants
@anveshmekala @jcfranco @driskull