Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Update Dark Mode color mapping for 4.0 #3122

Open
macandcheese opened this issue Sep 28, 2021 · 4 comments
Open

Enhancement: Update Dark Mode color mapping for 4.0 #3122

macandcheese opened this issue Sep 28, 2021 · 4 comments
Assignees
@SkyeSeitz @ashetland
Labels
1 - assigned Issues that are assigned to a sprint and a team member. breaking change Issues and pull requests with code changes that are not backwards compatible. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - lg Large design effort; 10-20 days of design work p - medium Issue is non core or affecting less that 60% of people using the library visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Milestone
2025-11-18 - 4.0....

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Sep 28, 2021 •
edited by geospatialem
Loading

Description

As a follow-up from a Teams conversation, we should explore "inverting" the dark mode paradigm to provide a better experience. Foreground colors should be lighter than background colors.

This is pretty standard across competitor design systems and seems like a good improvement.

Blocked issues: #10756

Link to Teams meeting where this was discussed: https://teams.microsoft.com/l/message/19:fd15b51dacd24e70895ec1218a54ae06@thread.skype/1626380916800?tenantId=aee6e3c9-711e-4c7c-bd27-04f2307db20d&groupId=56fae21a-9407-4943-859f-a9bfcf0bbad3&parentMessageId=1626380916800&teamName=Calcite%20Design%20System&channelName=Calcite%20Components&createdTime=1626380916800

https://material.io/design/color/dark-theme.html#properties

Relevant Info

🔗 Link to Figma specs

Part of 4.0's Phase I - Colors

Would require updating calcite-colors repository with resultant changes.
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 28, 2021
@macandcheese macandcheese added the design Issues that need design consultation prior to development. label Oct 5, 2021
@benelan benelan removed the needs triage Planning workflow - pending design/dev review. label Oct 13, 2021
@benelan benelan added this to the Freezer milestone Oct 13, 2021
@jcfranco jcfranco mentioned this issue Oct 15, 2021
Closed
@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Aug 23, 2022
@geospatialem
Copy link
Member

geospatialem commented Aug 23, 2022 •
edited
Loading

This issue is blocked awaiting creation of 863, which was included in the design phase of the new component, calcite-textarea. Prior to addressing this enhancement, the textarea component will be developed and implemented.

This applies to a different issue and the blocked label is now removed. See #3312. cc/ @ashetland

@geospatialem geospatialem removed the blocked This issue is blocked by another issue. label Aug 23, 2022
@macandcheese macandcheese changed the title Enhancement: Update Dark Theme Paradigm Enhancement: Update Dark Mode Paradigm Sep 20, 2022
@geospatialem geospatialem mentioned this issue Mar 3, 2023
Closed
@ashetland ashetland added needs triage Planning workflow - pending design/dev review. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jul 18, 2023
@SkyeSeitz
Copy link

Even while retaining the same box-shadow values as light mode, similar to Material Design (note below), this could improve the box-shadow contrast with surfaces in dark mode, which is currently pretty subtle.

image

@geospatialem
Copy link
Member

@SkyeSeitz With the above considerations, should we move this issue out of the freezer and consider it for a future design sprint?

@SkyeSeitz
Copy link

@geospatialem I don't believe there any issues with moving this issue out of the freezer 👍🏽
cc: @macandcheese for confirmation

@geospatialem geospatialem removed this from the Freezer milestone Jul 26, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@brittneytewks brittneytewks added the p - low Issue is non core or affecting less that 10% of people using the library label Aug 17, 2023
@brittneytewks brittneytewks added this to the Design Backlog milestone Aug 17, 2023
@brittneytewks brittneytewks removed the needs triage Planning workflow - pending design/dev review. label Aug 17, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@SkyeSeitz SkyeSeitz mentioned this issue Apr 17, 2024
Closed
@ashetland ashetland added the p - medium Issue is non core or affecting less that 60% of people using the library label Apr 30, 2024
@ashetland ashetland removed the p - low Issue is non core or affecting less that 10% of people using the library label Apr 30, 2024
@geospatialem geospatialem removed this from the Design Backlog milestone May 9, 2024
@geospatialem geospatialem added the estimate - design - lg Large design effort; 10-20 days of design work label May 9, 2024
@geospatialem geospatialem added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible label Sep 16, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 16, 2024
@geospatialem geospatialem changed the title Enhancement: Update Dark Mode Paradigm Enhancement: Update Dark Mode Paradigm for 4.0 Nov 18, 2024
@geospatialem geospatialem changed the title Enhancement: Update Dark Mode Paradigm for 4.0 Enhancement: Update Dark Mode color mapping for 4.0 Nov 18, 2024
@geospatialem geospatialem added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Nov 18, 2024
@geospatialem geospatialem mentioned this issue Nov 18, 2024
Open
9 tasks
@ashetland ashetland self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SkyeSeitz SkyeSeitz

@ashetland ashetland

Labels
1 - assigned Issues that are assigned to a sprint and a team member. breaking change Issues and pull requests with code changes that are not backwards compatible. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - lg Large design effort; 10-20 days of design work p - medium Issue is non core or affecting less that 60% of people using the library visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2025-11-18 - 4.0.0 Nov Breaking Chang...
Development

No branches or pull requests
7 participants
@alisonailea @macandcheese @geospatialem @benelan @SkyeSeitz @ashetland @brittneytewks