Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make npm dedupe work #10481

Closed
maxpatiiuk opened this issue Oct 3, 2024 · 2 comments
Closed

Make npm dedupe work #10481

maxpatiiuk opened this issue Oct 3, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Milestone
2024-11-26 - 3.0....

Comments

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Oct 3, 2024 •
edited
Loading

Priority impact

p - low

Summary

Yarn has a very important command yarn dedupe for avoiding duplicate versions of the same dependency being present in the codebase (which can cause issues due for dependencies that rely on global state)

NPM has an equivalent npm dedupe command, however, it is failing in the Calcite monorepo:

Screenshot 2024-10-02 at 22 13 46

The error might get fixed by #10465

Desired Outcome

Fixing the errors reported by this command would be quite useful for the Lumina migration as I am seeing duplicate versions of dependencies like vite/vitest/puppeteer/postcss, that are causing issues.

image

Resources

No response
@maxpatiiuk maxpatiiuk added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 3, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Oct 3, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 7, 2024
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Oct 9, 2024
@jcfranco jcfranco added this to the 2024-10-29 - Oct Milestone milestone Oct 9, 2024
@jcfranco jcfranco added the estimate - 5 A few days of work, definitely requires updates to tests. label Oct 9, 2024
@jcfranco jcfranco mentioned this issue Oct 23, 2024
Merged
@jcfranco jcfranco mentioned this issue Nov 5, 2024
Closed
jcfranco added a commit that referenced this issue Nov 15, 2024
@maxpatiiuk @jcfranco
@benelan @calcite-admin @renovate
refactor!: migrate to Lumina (#10482)
b2c9762 
**Related Issue:** #10310, #10481, #10399, #10405, #10491, #10434,
#10495, #9260

## Noteworthy changes

* components are now Lit-based
* removed `@storybook/test` and `@storybook/addon-interactions` as these
were not being actively used
* React deps bumped to v18
* Added default `scale` value to:
  * `action-bar`
  * `action-group`
  * `action-menu`
  * `action-pad`
* Path of extras will change to the following:
* `/dist/extras/vscode-data.json` ➡️
`/dist/docs/vscode.html-custom-data.json`
* backwards-compatible version is preserved to not break Intellisense
[described in the
doc](https://developers.arcgis.com/calcite-design-system/resources/frameworks/#visual-studio-intellisense)
	* `/dist/extras/docs-json.json` ➡️ `/dist/docs/docs.json` (internal)
* `/dist/extras/translations-json.json` ➡️
`/dist/docs/translations.json` (internal)
	* `/dist/extras/docs-json.d.ts` ❌ (removed, internal)

BREAKING CHANGE: 

* for a consistent development experience, components now convert `null`
to `undefined`, so developers will need to update code with strict null
checks
* removed the following `@esri/eslint-plugin-calcite-components` rules
as they are no longer valid:
	* `ban-props-on-host`
	* `enforce-ref-last-prop`
	* `require-event-emitter-type`

---------

Co-authored-by: JC Franco <jfranco@esri.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 15, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 15, 2024

Verified locally, ran with no errors 👌

@DitwanP DitwanP closed this as completed Nov 15, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @maxpatiiuk @DitwanP