Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Improve Ember instructions #6

Merged
merged 6 commits into from
Jul 27, 2020
Merged

Improve Ember instructions #6

merged 6 commits into from
Jul 27, 2020

Conversation

ffaubry
Copy link
Member

@ffaubry ffaubry commented Jul 27, 2020

The ember instructions were not accurate enough.
This PR proposed to improve the way calcite-components are included in the build and initialized at runtime.
It discourages using ember-cli-stencil and this package is not well maintained and doesn't offer the flexibility for managing the calcite components assets.
A better solution is offered to include the calcite components assets in the build.
A new section describes how to use calcite components with JSAPI in an Ember app.

ember/README.md Outdated Show resolved Hide resolved
ember/README.md Outdated Show resolved Hide resolved
ember/README.md Outdated Show resolved Hide resolved
// define calcite components' custom elements on the window
// define the resource Url as wellmber
defineCustomElements(window, {
resourcesUrl: "assets/calcite/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@paulcpederson
Copy link
Member

Nice, this is a great improvement, thanks @ffaubry !

ffaubry and others added 3 commits July 27, 2020 10:33
Co-authored-by: Paul Pederson <paul.c.pederson@gmail.com>
Co-authored-by: Paul Pederson <paul.c.pederson@gmail.com>
Co-authored-by: Paul Pederson <paul.c.pederson@gmail.com>
@paulcpederson
Copy link
Member

I think this addresses #3 and #4 as well, so adding references here.

@ffaubry
Copy link
Member Author

ffaubry commented Jul 27, 2020

Thx @paulcpederson for reviewing and fixing typos.
I cannot merge. You will have to do it.

@ffaubry
Copy link
Member Author

ffaubry commented Jul 27, 2020

@paulcpederson it addresses half of #3 and fully #4
I will let @tomwayson address ember-esri-loader issue.

@paulcpederson
Copy link
Member

👍

@ffaubry
Copy link
Member Author

ffaubry commented Jul 27, 2020

Thx @paulcpederson

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants