fix !help outside server showing extra commands it shouldnt

Erisa · Jan 13, 2025 · db7b569 · db7b569
1 parent ef70e65
commit db7b569
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/Commands/GlobalCmds.cs b/Commands/GlobalCmds.cs
@@ -337,18 +337,20 @@ private async Task<IEnumerable<ContextCheckAttribute>> CheckPermissionsAsync(Com
 
             foreach (var check in contextChecks)
             {
-                if (check is HomeServerAttribute homeServerAttribute)
+                // if command requiring homes erver is used outside, fail the check
+                if (check is HomeServerAttribute homeServerAttribute
+                    && (ctx.Channel.IsPrivate || ctx.Guild is null || ctx.Guild.Id != Program.cfgjson.ServerID)
+                   )
                 {
-                    if (ctx.Channel.IsPrivate || ctx.Guild is null || ctx.Guild.Id != Program.cfgjson.ServerID)
-                    {
-                        failedChecks.Add(homeServerAttribute);
-                    }
+                    failedChecks.Add(homeServerAttribute);
                 }
 
                 if (check is RequireHomeserverPermAttribute requireHomeserverPermAttribute)
                 {
-                    // Fail if guild member is null but this cmd does not work outside of the home server
-                    if (member is null && !requireHomeserverPermAttribute.WorkOutside)
+                    // Fail if guild is wrong but this command does not work outside of the home server
+                    if (
+                        (ctx.Channel.IsPrivate || ctx.Guild is null || ctx.Guild.Id != Program.cfgjson.ServerID)
+                        && !requireHomeserverPermAttribute.WorkOutside)
                     {
                         failedChecks.Add(requireHomeserverPermAttribute);
                     }