Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve caching of images from EVE image server #57

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Improve caching of images from EVE image server #57

merged 7 commits into from
Jan 16, 2025

Conversation

ErikKalkoken
Copy link
Owner

Key changes

  • Now uses DB instead of file system for caching eve images fetched from image server
  • Adds new pcache package implementing a persistent cache
  • Changes type of cache keys from any to string for better type safety
  • Introduce timeouts for some images (e.g. character images)

Rationale

  • Improved performance for fetching cached images
  • Makes it easier to potentially add mobile support in the future

@ErikKalkoken ErikKalkoken merged commit aca0ad8 into main Jan 16, 2025
8 checks passed
@ErikKalkoken ErikKalkoken deleted the rewrite-eveimage-cache branch January 16, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ErikKalkoken