-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare solution for potential migration to kubernetes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrated a new EncryptionService for encrypting and decrypting tokens. Updated controllers and services to utilize the encryption functionality and added necessary environment configuration.
Deleted the production `docker-compose.production.yml` file, updated Docker container names and environment variables for development, and enhanced variable consistency in `docker-compose.development.yml` and `.env.example`. Also, added missing files to the solution and adjusted common environment settings across configurations.
Converted environment variables from array notation to colon notation to ensure proper parsing. Added named volume for PostgreSQL data persistence to avoid data loss on container recreation.
Change POSTGRES_USER to 'blink3' in .env.example. Adjust docker-compose.yml to use this updated environment variable for REDIS_NAME. Removed redundant REDIS_NAME entry in .env.example.
Upgraded various package dependencies across multiple projects to their latest versions to maintain compatibility and address potential vulnerabilities. The updates span different libraries and frameworks, ensuring overall system stability and performance improvements.
Introduce GitToolBoxBlameSettings in the project config for better Git integration in the IDE. Simplify production Docker Compose command in README by removing unnecessary overrides.
Eliminated an exposed ENCRYPTION_KEY variable from the configuration to enhance security. Also, standardized service names in the Docker Compose setup for consistency with naming conventions.
Deleted obsolete Docker run configurations and removed `appsettings.Development.json` references. Updated Dockerfile and docker-compose files to use environment variables for configuration, simplifying deployment.
Removed hard-coded environment variables from docker-compose files and added them to .env.example for better configuration management. This change simplifies updating variables across different environments by using a single source.
Migrated from DiscordSocketClient to DiscordRestClient in all relevant controllers. Updated methods to improve caching strategy for guilds and channels. Removed Discord.Addons.Hosting package and revised constructors and dependency injections accordingly.
Removed the nullable marker for the RestGuild type to ensure that a non-nullable RestGuild instance is always expected from GetGuildAsync method. This change increases type safety by preventing potential null reference exceptions.
The Discord bot token environment variable has been relocated from the global to the service-specific environment section in docker-compose.yml. This ensures it is only available to the relevant service, improving security and configuration clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains some changes and fixes to improve overall architecture, in preparation for future migration to kubernetes.