Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 313 enum variants #73

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Fix 313 enum variants #73

merged 4 commits into from
Mar 4, 2025

Conversation

JR-1991
Copy link
Member

@JR-1991 JR-1991 commented Mar 3, 2025

As highlighted in #72 the enumeration variants for units need to explicitly implement enum.members to allow the usage of partial in a non-context environment. Tests have been extended to Python 3.13 to check possible other future incompatibilites.

@jmrohwer can you please test it to verify it is working on your machine too?


This change is Reviewable

@JR-1991 JR-1991 added the bug Something isn't working label Mar 3, 2025
@JR-1991 JR-1991 self-assigned this Mar 3, 2025
@JR-1991 JR-1991 marked this pull request as draft March 3, 2025 14:49
@JR-1991 JR-1991 marked this pull request as ready for review March 3, 2025 14:52
@jmrohwer
Copy link
Member

jmrohwer commented Mar 4, 2025

👍 Works for me as well

@JR-1991
Copy link
Member Author

JR-1991 commented Mar 4, 2025

@jmrohwer perfect, thanks! Merged 🙌

@JR-1991 JR-1991 merged commit 766ab6c into v2-migration Mar 4, 2025
6 checks passed
@JR-1991 JR-1991 deleted the fix-313-enum-variants branch March 4, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants