From 1a48adf7a3b30e5c069bdb9aae4bfdd17253df41 Mon Sep 17 00:00:00 2001 From: Milan Kloewer Date: Wed, 19 Feb 2025 17:29:57 +0000 Subject: [PATCH 1/3] don't trace VersionNumber --- src/Tracing.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Tracing.jl b/src/Tracing.jl index 3ff25d69c..5b8b0630d 100644 --- a/src/Tracing.jl +++ b/src/Tracing.jl @@ -35,6 +35,7 @@ for T in ( Integer, RNumber, Val, + VersionNumber, ) @eval Base.@nospecializeinfer function traced_type_inner( @nospecialize(T::Type{<:$T}), From a6695c2b18f17e3dbc7bb8bf9f0ebb2e93b74d63 Mon Sep 17 00:00:00 2001 From: Milan Kloewer Date: Wed, 19 Feb 2025 17:40:53 +0000 Subject: [PATCH 2/3] add tracing tests for VersionNumber --- test/tracing.jl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/tracing.jl b/test/tracing.jl index 9bf81daa1..0b25c5893 100644 --- a/test/tracing.jl +++ b/test/tracing.jl @@ -242,4 +242,9 @@ end st_traced = Reactant.to_rarray(st; track_numbers=Number) @test st_traced.training isa Val{true} end + + @testset "no trace VersionNumber" begin + @test Reactant.to_rarray(VersionNumber(1)) isa VersionNumber + @test @inferred Reactant.to_rarray(VersionNumber(1)) isa VersionNumber + end end From ce11e73241cbcbccb0f4832acd5fdb1a9ecbe2a9 Mon Sep 17 00:00:00 2001 From: Milan Kloewer Date: Wed, 19 Feb 2025 17:54:18 +0000 Subject: [PATCH 3/3] include in existing testsets --- test/tracing.jl | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/test/tracing.jl b/test/tracing.jl index 0b25c5893..4666aefb4 100644 --- a/test/tracing.jl +++ b/test/tracing.jl @@ -30,6 +30,7 @@ end (Char, Char, Char), (AbstractString, AbstractString, AbstractString), (String, String, String), + (VersionNumber, VersionNumber, VersionNumber), # Numeric types (AbstractFloat, AbstractFloat, AbstractFloat), @@ -242,9 +243,4 @@ end st_traced = Reactant.to_rarray(st; track_numbers=Number) @test st_traced.training isa Val{true} end - - @testset "no trace VersionNumber" begin - @test Reactant.to_rarray(VersionNumber(1)) isa VersionNumber - @test @inferred Reactant.to_rarray(VersionNumber(1)) isa VersionNumber - end end