Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't trace VersionNumber #773

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Don't trace VersionNumber #773

merged 3 commits into from
Feb 19, 2025

Conversation

milankl
Copy link
Contributor

@milankl milankl commented Feb 19, 2025

fixes #767

wsmoses
wsmoses reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to tracing.jl

@milankl
Copy link
Contributor Author

milankl commented Feb 19, 2025

wasn't sure whether to use @test @inferred or not, but it passes with or without so it's two tests now

@wsmoses
Copy link
Member

wsmoses commented Feb 19, 2025

A bit more simply you can add to something around here

Reactant.jl/test/tracing.jl

Line 23 in acaabc4

(Any, Any, Any),

@wsmoses wsmoses merged commit afa90a4 into EnzymeAD:main Feb 19, 2025
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracing VersionNumber
2 participants
@milankl @wsmoses