Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing VersionNumber #767

Closed
milankl opened this issue Feb 18, 2025 · 1 comment · Fixed by #773
Closed

Tracing VersionNumber #767

milankl opened this issue Feb 18, 2025 · 1 comment · Fixed by #773

Comments

@milankl
Copy link
Contributor

milankl commented Feb 18, 2025

Error that occured with Reactant.to_rarray from SpeedyWeather/SpeedyWeather.jl#674

julia> VersionNumber(1)
v"1.0.0"

julia> Reactant.to_rarray(VersionNumber(1))
ERROR: UndefRefError: access to undefined reference
Stacktrace:
  [1] getproperty
    @ ./Base.jl:49 [inlined]
  [2] traced_type_inner(T::Core.TypeofVararg, seen::Dict{…}, mode::Reactant.TraceMode, track_numbers::Type, sharding::Any)
    @ Reactant ~/.julia/packages/Reactant/VrYgz/src/Tracing.jl:148
  [3] traced_tuple_type_inner(T::Type{…}, seen::Dict{…}, mode::Reactant.TraceMode, track_numbers::Type, sharding::Any)
    @ Reactant ~/.julia/packages/Reactant/VrYgz/src/Tracing.jl:135
  [4] traced_type_inner(T::Type{…}, seen::Dict{…}, mode::Reactant.TraceMode, track_numbers::Type, sharding::Any)
    @ Reactant ~/.julia/packages/Reactant/VrYgz/src/Tracing.jl:171
  [5] traced_type_inner(T::Type, seen::Dict{Type, Type}, mode::Reactant.TraceMode, track_numbers::Type, sharding::Any)
    @ Reactant ~/.julia/packages/Reactant/VrYgz/src/Tracing.jl:540
  [6] traced_type(T::Type, ::Val{Reactant.ArrayToConcrete}, track_numbers::Type, sharding::Reactant.Sharding.NoSharding)
    @ Reactant ~/.julia/packages/Reactant/VrYgz/src/Tracing.jl:716
  [7] make_tracer(seen::Reactant.OrderedIdDict{…}, prev::Any, path::Any, mode::Reactant.TraceMode; track_numbers::Type, sharding::Any, kwargs::@Kwargs{})
    @ Reactant ~/.julia/packages/Reactant/VrYgz/src/Tracing.jl:779
  [8] to_rarray_internal(x::Any, track_numbers::Type, sharding::Any)
    @ Reactant ~/.julia/packages/Reactant/VrYgz/src/Tracing.jl:1411
  [9] #to_rarray#89
    @ ~/.julia/packages/Reactant/VrYgz/src/Tracing.jl:1405 [inlined]
 [10] to_rarray(x::Any)
    @ Reactant ~/.julia/packages/Reactant/VrYgz/src/Tracing.jl:1399
 [11] top-level scope
    @ REPL[26]:1
Some type information was truncated. Use `show(err)` to see complete types.
@wsmoses
Copy link
Member

wsmoses commented Feb 19, 2025

we should just explicitly not consider version number as a traced type, basically adding it to

if you want to give it a go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants