Skip to content

Commit

Permalink
[GHA] Run x86_64 macOS jobs on macOS-13 runners (#765)
Browse files Browse the repository at this point in the history
* [GHA] Run x86_64 macOS jobs on `macOS-13` runners

`macOS-13` is native x86_64 hardware and avoids running through Rosetta, which
can lead to nasty test failures.

* [GHA] Add timeout for test jobs
  • Loading branch information
giordano authored Feb 17, 2025
1 parent 4ece29d commit c817f8a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 18 deletions.
23 changes: 5 additions & 18 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ concurrency:

jobs:
test:
name: Julia ${{ matrix.version }} - ${{ matrix.test_group }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ matrix.libReactant }} libReactant - assertions=${{ matrix.assertions }} - ${{ github.event_name }}
timeout-minutes: 90
name: Julia ${{ matrix.version }} - ${{ matrix.test_group }} - ${{ matrix.os }} - ${{ matrix.libReactant }} libReactant - assertions=${{ matrix.assertions }} - ${{ github.event_name }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand All @@ -46,63 +47,49 @@ jobs:
# `ubuntu-22.04-arm` is considered more stable than `ubuntu-24.04-arm`:
# <https://github.com/orgs/community/discussions/148648#discussioncomment-12099554>.
- ubuntu-22.04-arm
- macOS-13
- macOS-latest
test_group:
- core
- neural_networks
- integration
arch:
- x64
- aarch64
assertions:
- false
libReactant: [packaged]
include:
- os: ubuntu-24.04
arch: x64
libReactant: packaged
version: '1.10'
assertions: true
test_group: core
- os: ubuntu-24.04
arch: x64
libReactant: packaged
version: '1.10'
assertions: true
test_group: neural_networks
- os: ubuntu-24.04
arch: x64
libReactant: packaged
version: '1.10'
assertions: true
test_group: integration
# - os: ubuntu-24.04
# arch: x86
# libReactant: packaged
# version: '1.10'
# test_group: core
# - os: ubuntu-24.04
# arch: x86
# libReactant: packaged
# version: '1.10'
# test_group: neural_networks
# - os: ubuntu-24.04
# arch: x86
# libReactant: packaged
# version: '1.10'
# test_group: integration
exclude:
- os: ubuntu-24.04 # this is x86_64, exclude foreign architecture
arch: aarch64
- os: ubuntu-22.04-arm # this is aarch64, exclude foreign architecture
arch: x64
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
if: ${{ ! matrix.assertions }}
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: julia-actions/cache@v2
- uses: actions/checkout@v4
if: ${{ matrix.assertions }}
Expand All @@ -117,15 +104,15 @@ jobs:
make -C julia -j $(nproc) FORCE_ASSERTIONS=1 LLVM_ASSERTIONS=1 JULIA_PRECOMPILE=0
echo $PWD/julia/usr/bin >> $GITHUB_PATH
- name: Build libReactant
if: ${{ matrix.libReactant == 'local' && matrix.os != 'macOS-latest'}}
if: ${{ matrix.libReactant == 'local' && !startsWith(matrix.os, 'macOS-') }}
id: build_libreactant
run: |
python -m pip install numpy
julia --color=yes --project=deps -e 'using Pkg; Pkg.instantiate()'
julia --color=yes --project=deps deps/build_local.jl
cp LocalPreferences.toml test/
- name: Build libReactant MacOS
if: ${{ matrix.libReactant == 'local' && matrix.os == 'macOS-latest'}}
if: ${{ matrix.libReactant == 'local' && !startsWith(matrix.os, 'macOS-') }}
id: build_libreactant_mac
run: |
python -m pip install numpy
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/downgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ concurrency:
jobs:
downgrade:
# if: ${{ !contains(github.event.head_commit.message, '[skip tests]') && github.base_ref == github.event.repository.default_branch }}
timeout-minutes: 90
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down

0 comments on commit c817f8a

Please sign in to comment.