-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import PATO:'chronological age' #1588
Import PATO:'chronological age' #1588
Conversation
Hi @timalamenciak this sets up the import target, but you'll have to trigger the import process in the Makefile, in the docker container. you'll see that the pato import owl file will change too |
Thanks @timalamenciak I'm not sure why the make process for PATO generates an OWL file with so much CHEBI in it. The PATO terms we need are in there. Is this why there's a merge process downstream ? |
See: https://oboacademy.github.io/obook/tutorial/project-ontology-development/?h=slme#extracting-modules I updated this to document the new |
It's still unclear why so many CHEBI terms are in the PATO import. But if this is expected behaviour, then @timalamenciak we can disregard
We won't use OBO format anymore - it's a lock in and anti-FAIR. I assume robot can process other formats for the subset definition ? |
The reason you have Uberon classes in the PATO import is because Description Logic based SLME module extraction demands it (an ontology is the union of all its base axioms plus all imported axioms, and given a signature, you have to import all relevant axioms, including imported ones). However, we have long overcome this limitation in our build process - we just need some funding for ENVO to fix all of this. Chris solution has nothing to do with OBO format, maybe this is a bit misleading in the description in the PR we merged. Its just a sane way to extract a less lossy MIREOT style module which is very prevalent in many OBO ontology development processes. But there is another way, which is using base files. This allows us to extract PATO terms from PATO while preserving any logical links to other ontologies as well. However, we need some amount of funding to implement this in ENVO. This is unrelated though to this PR here and should be attacked separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment to explain the unrelated axioms, but this should not be handled as part of this PR here!
If you have overcome this somewhere in OBO, yet need ontology specific funding to deploy it over the hundreds of ontologies that are OBO Library assets, something is deeply wrong. Is there documentation you can point to that describes how to get from the current ENVO build process (which was OBO compliant) to the new one?
Yes it does. The command specifies OBO format input.
That's parallel - the process is fine, the apparent requirement for OBO files isn't.
Where is the documentation explaining how to do this? If it's standard OBO approaches, why does each ontology need dedicated funding to remain current? Something is not working. |
Per import process here: https://github.com/EnvironmentOntology/envo/wiki/Import-terms-from-other-ontologies - closes #1587