Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import PATO:'chronological age' #1588

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

timalamenciak
Copy link
Contributor

@pbuttigieg
Copy link
Member

Hi @timalamenciak this sets up the import target, but you'll have to trigger the import process in the Makefile, in the docker container.

you'll see that the pato import owl file will change too

@pbuttigieg
Copy link
Member

Thanks @timalamenciak

@matentzn @cmungall

I'm not sure why the make process for PATO generates an OWL file with so much CHEBI in it.

The PATO terms we need are in there.

Is this why there's a merge process downstream ?

@cmungall
Copy link
Member

cmungall commented Dec 18, 2024

I'm not sure why the make process for PATO generates an OWL file with so much CHEBI in it.

See: https://oboacademy.github.io/obook/tutorial/project-ontology-development/?h=slme#extracting-modules
For the most accessible description.

I updated this to document the new subset method, which is what ENVO should use: https://robot.obolibrary.org/extract#subset

@pbuttigieg
Copy link
Member

I'm not sure why the make process for PATO generates an OWL file with so much CHEBI in it.

See: https://oboacademy.github.io/obook/tutorial/project-ontology-development/?h=slme#extracting-modules
For the most accessible description.

It's still unclear why so many CHEBI terms are in the PATO import. But if this is expected behaviour, then @timalamenciak we can disregard

I updated this to document the new subset method, which is what ENVO should use: https://robot.obolibrary.org/extract#subset

We won't use OBO format anymore - it's a lock in and anti-FAIR. I assume robot can process other formats for the subset definition ?

@pbuttigieg pbuttigieg changed the title Added 'chronological age' to pato_terms.txt Import PATO:'chronological age' Dec 18, 2024
@matentzn
Copy link
Collaborator

matentzn commented Dec 28, 2024

The reason you have Uberon classes in the PATO import is because Description Logic based SLME module extraction demands it (an ontology is the union of all its base axioms plus all imported axioms, and given a signature, you have to import all relevant axioms, including imported ones). However, we have long overcome this limitation in our build process - we just need some funding for ENVO to fix all of this.

Chris solution has nothing to do with OBO format, maybe this is a bit misleading in the description in the PR we merged. Its just a sane way to extract a less lossy MIREOT style module which is very prevalent in many OBO ontology development processes. But there is another way, which is using base files. This allows us to extract PATO terms from PATO while preserving any logical links to other ontologies as well. However, we need some amount of funding to implement this in ENVO.

This is unrelated though to this PR here and should be attacked separately.

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment to explain the unrelated axioms, but this should not be handled as part of this PR here!

@pbuttigieg
Copy link
Member

The reason you have Uberon classes in the PATO import is because Description Logic based SLME module extraction demands it (an ontology is the union of all its base axioms plus all imported axioms, and given a signature, you have to import all relevant axioms, including imported ones). However, we have long overcome this limitation in our build process - we just need some funding for ENVO to fix all of this.

If you have overcome this somewhere in OBO, yet need ontology specific funding to deploy it over the hundreds of ontologies that are OBO Library assets, something is deeply wrong. Is there documentation you can point to that describes how to get from the current ENVO build process (which was OBO compliant) to the new one?

Chris solution has nothing to do with OBO format, maybe this is a bit misleading in the description in the PR we merged.

Yes it does. The command specifies OBO format input.

Its just a sane way to extract a less lossy MIREOT style module which is very prevalent in many OBO ontology development processes.

That's parallel - the process is fine, the apparent requirement for OBO files isn't.

But there is another way, which is using base files. This allows us to extract PATO terms from PATO while preserving any logical links to other ontologies as well. However, we need some amount of funding to implement this in ENVO.

Where is the documentation explaining how to do this? If it's standard OBO approaches, why does each ontology need dedicated funding to remain current? Something is not working.

@pbuttigieg pbuttigieg merged commit 4790433 into EnvironmentOntology:master Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import PATO:0001486
4 participants