fix: handle null value percentage + set as null if percentage can't b…

…e calculated (#47)
EntropiaTally · Mar 3, 2022 · f7832d2 · f7832d2
1 parent 973a42a
commit f7832d2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/main/session.js b/src/main/session.js
@@ -212,7 +212,11 @@ class Session {
         .reduce((previous, current) => previous + current.total, 0);
 
       for (const key in this.aggregated[type]) {
-        this.aggregated[type][key].percent = Number((this.aggregated[type][key].total / typeTotal) * 100);
+        if (this.aggregated[type][key].total > 0 && typeTotal > 0) {
+          this.aggregated[type][key].percent = Number((this.aggregated[type][key].total / typeTotal) * 100);
+        } else {
+          this.aggregated[type][key].percent = null;
+        }
       }
     }
   }

diff --git a/src/ui/pages/hunting/views/loot-view.jsx b/src/ui/pages/hunting/views/loot-view.jsx
@@ -106,7 +106,7 @@ const LootView = () => {
                 <td>{row.key}</td>
                 <td>{row.count.toLocaleString()}</td>
                 <td><span className="sum">{row.total.toFixed(2)}</span> PED</td>
-                <td>{row.percent.toFixed(2)} %</td>
+                <td>{row.percent ? `${row.percent.toFixed(2)} %` : '--' }</td>
               </tr>
             ))}
           </Table>