fix(bug): Fix dashboard tab loading #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiffanyvu
temporarily deployed
to
fix-tabs-kibana
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-tabs-app
GitHub Actions
Inactive
andieswift
temporarily deployed
to
fix-tabs-app
GitHub Actions
Inactive
andieswift
temporarily deployed
to
fix-tabs-kibana
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-tabs-kibana
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-tabs-app
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-tabs-kibana
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-tabs-app
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-tabs-kibana
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-tabs-app
GitHub Actions
Inactive
andieswift
approved these changes
Feb 26, 2025
13bfrancis
approved these changes
Feb 26, 2025
|
🎉 This PR is included in version 1.5.0-val.138 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Linked Ticket
OY2-32759
💬 Description / Notes
When switching between tabs on the dashboard, invalid data for the new tab is briefly rendered before the data is ready.
The previous PR for this ticket created an unintentional bug because it involved checking for the loading state of the data, however, the search bar and filters also depend on that loading state.
PR undoing the change: #1208
🛠 Changes
Logic for loading a tab is separated so that it doesn't affect search and filtering functionality.
📸 Screenshots / Demo