Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gene segment info from the CDS #370

Merged
merged 3 commits into from
May 21, 2024
Merged

Gene segment info from the CDS #370

merged 3 commits into from
May 21, 2024

Conversation

MatBarba
Copy link
Contributor

We get the gene segment information from the transcript itself, but in some cases the information is in their CDS, this PR adds this extra check.

Rewrite the code with a new exception GeneSegmentError when we can't get the information to make the proper biotype.

@MatBarba MatBarba self-assigned this May 21, 2024
Copy link
Contributor

@JAlvarezJarreta JAlvarezJarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny suggestion, but looks good to me 👍

@MatBarba MatBarba requested a review from JAlvarezJarreta May 21, 2024 15:22
@MatBarba MatBarba merged commit 0adbba3 into main May 21, 2024
1 check passed
@MatBarba MatBarba deleted the mbarba/gene_segment_cds2 branch May 21, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants