Disha/update func anno #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dishalodha
requested review from
vsitnik,
JAlvarezJarreta and
MatBarba
and removed request for
JAlvarezJarreta
JAlvarezJarreta
requested changes
Mar 5, 2024
Tweak and exclude synonyms if in xrefs
Co-authored-by: J. Alvarez-Jarreta <jalvarez@ebi.ac.uk>
Co-authored-by: J. Alvarez-Jarreta <jalvarez@ebi.ac.uk>
Co-authored-by: J. Alvarez-Jarreta <jalvarez@ebi.ac.uk>
MatBarba
approved these changes
Mar 7, 2024
JAlvarezJarreta
requested review from
JAlvarezJarreta
and removed request for
JAlvarezJarreta
JAlvarezJarreta
approved these changes
Mar 8, 2024
Co-authored-by: J. Alvarez-Jarreta <jalvarez@ebi.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add xrefs to functional_annotation.json file as the current code only adds synonyms and uses default dbname (BRC4_Community_Annotation) to load all the xrefs which is incorrect.
I have added an xrefs array for transcripts and translations using provider_name as dbname and name.
Vasily and I also found a bug in loading load_fann.pl file where the external_dbs were loaded as dictionary and not an array of dict causing the same db_name to overwrite even though the pattern is different in the config file (config/external_db_map/default.txt)