Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail but write a stats error file #288

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

MatBarba
Copy link
Contributor

@MatBarba MatBarba commented Feb 7, 2024

Instead of dying when stats do not match, simply create a stats error file that we can easily see after the script (and the prepare genome pipeline) is over.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@JAlvarezJarreta JAlvarezJarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 The only relevant bit of my review is the errors_file extension, the other part is just a preference.

MatBarba and others added 2 commits February 7, 2024 16:27
Co-authored-by: J. Alvarez-Jarreta <jalvarez@ebi.ac.uk>
@JAlvarezJarreta JAlvarezJarreta merged commit d2683c8 into main Feb 7, 2024
1 check passed
@JAlvarezJarreta JAlvarezJarreta deleted the mbarba/stats_error_file branch February 7, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants