Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE Vanilla items removal + bunch of fixes. #797

Merged
merged 16 commits into from
Dec 6, 2023

Conversation

Kanzaji
Copy link
Contributor

@Kanzaji Kanzaji commented Dec 2, 2023

This PR Resolves: #677 / #731 / Theoretically #744 , as it fixes few of the issues mentioned there

Required mods:

Changes:

Changes from Mod Updates:

  • EMI: Now jsons can have priorities 😄 What allows for better organization of EMI jsons used to modify visibility of the stacks. For now used only in addition json, so it takes priority over jsons for unification and hidden/disabled.

  • EECreateAddon: Fixes a crash that didn't allow us to remove EE Vanilla replacements

  • EE PR: Fixes spam in the log from Apotheosis about missing models.

@Kanzaji
Copy link
Contributor Author

Kanzaji commented Dec 3, 2023

Just saying that the PR is ready for review ❤️

Copy link
Contributor

@NielsPilgaard NielsPilgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work!

I would however like the functional storage jsons turned into a script :)

@Kanzaji
Copy link
Contributor Author

Kanzaji commented Dec 5, 2023

Was meant to work on that yeasterday, but it turned out I was way too tired after coming back home to touch this, so I've made it today 😅 Sorry for bit of the delay >.>

Copy link
Contributor

@NielsPilgaard NielsPilgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@NielsPilgaard
Copy link
Contributor

@MuteTiefling would you mind having a quick look as well, if you have time? :)

@NielsPilgaard NielsPilgaard added Enhancement Bug Modpack specific bug. and removed Enhancement labels Dec 5, 2023
@MuteTiefling
Copy link
Contributor

Thanks for the reminder. Meant to look at this last night. Should have time tonight

@MuteTiefling
Copy link
Contributor

I wonder if we shouldn't take this opportunity to review things like Andesite, source gems, and carminite as well. I know I was the one that suggested they be given their own EE replacements at the time, but @theboo is right, they should have just been retextures.

Also, I think Create didn't even have an andesite block at the time, but now it does.

Copy link
Contributor

@MuteTiefling MuteTiefling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good where it's at. I do wonder about the other items I mentioned, but that can always go in a different update (or never).

@NielsPilgaard NielsPilgaard merged commit ef0a0d0 into EnigmaticaModpacks:develop Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Modpack specific bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants