-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EE Vanilla items removal + bunch of fixes. #797
Conversation
…idden_disabled.js
…w only in normal.
Buuz... why you don't want to fix this at the source >.>
Just saying that the PR is ready for review ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice work!
I would however like the functional storage jsons turned into a script :)
kubejs/data/functionalstorage/recipes/custom_compacting/amethyst.json
Outdated
Show resolved
Hide resolved
Was meant to work on that yeasterday, but it turned out I was way too tired after coming back home to touch this, so I've made it today 😅 Sorry for bit of the delay >.> |
kubejs/server_scripts/base/recipes/functionalstorage/compacting.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
@MuteTiefling would you mind having a quick look as well, if you have time? :) |
Thanks for the reminder. Meant to look at this last night. Should have time tonight |
I wonder if we shouldn't take this opportunity to review things like Andesite, source gems, and carminite as well. I know I was the one that suggested they be given their own EE replacements at the time, but @theboo is right, they should have just been retextures. Also, I think Create didn't even have an andesite block at the time, but now it does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good where it's at. I do wonder about the other items I mentioned, but that can always go in a different update (or never).
…r EE Vanilla items
This PR Resolves: #677 / #731 / Theoretically #744 , as it fixes few of the issues mentioned there
Required mods:
EMI - 1.0.26 Due to containing:
Add support for Priority in the Resource Pack json files, used to edit Stack Visibility emilyploszaj/emi#337
EECreateAddon - 1.0.2 Due to containing:
Fix a crash when Crushed ore processing type is present without ingot type. Ridanisaurus/EECreateAddon#4
EmendatusEnigmatica - 2.1.6
Fix
com/ridanisaurus/emendatusenigmatica/datagen/base/GeneratedPack.java
to check Predicate on the results, instead of just ignoring it. Ridanisaurus/EmendatusEnigmatica#214Rid is planning on updating EE near Xmas with lots of bug fixes, so just saying that when it happens, we should remember to update 😄
Changes:
Removed EE Replacements for Vanilla items!
Part of the fix of Missing World Generation Info for certain ores / Ores not showing in JEI #677
Re-implemented JEI Addition support. Created separation between addition to base / normal / expert 😄 (Even tho not used much, the code is in there if changes are required in the future)
Fixed missing ores / generation information from Missing World Generation Info for certain ores / Ores not showing in JEI #677
Added compat for blocks mentioned in Amethyst can get duped or reduced with compacting drawers #731 and fixed the Amethyst dupe 😄
Fixed few issues mentioned in commets of Found disabled items in create dungeon #744 (Disabled items were probably found in place we can't easily unify, so the issue is technically not fixed >.>)
Changed positioning of few added stacks in EMI, so they are in more natural places and not at the end of the list. (Doesn't affect JEI)
Adds missing texture for Andesite Alloy block (Credits as always to @Ridanisaurus ❤️)
Changes from Mod Updates:
EMI: Now jsons can have priorities 😄 What allows for better organization of EMI jsons used to modify visibility of the stacks. For now used only in addition json, so it takes priority over jsons for unification and hidden/disabled.
EECreateAddon: Fixes a crash that didn't allow us to remove EE Vanilla replacements
EE PR: Fixes spam in the log from Apotheosis about missing models.