Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potion Melder duplicates Potions #750

Open
SeooY opened this issue Nov 1, 2023 · 3 comments
Open

Potion Melder duplicates Potions #750

SeooY opened this issue Nov 1, 2023 · 3 comments
Labels
Bug Modpack specific bug. Mod Issue Bug within a mod. Status: Reported Mod issue has been reported.

Comments

@SeooY
Copy link

SeooY commented Nov 1, 2023

Modpack Version

1.15.1

Describe your issue.

With the current configuration, where only 1 dose of each input potion is consumed to create 2 doses of the output potion, the Potion Melder can duplicate potions. This can happen by melding the intended duplication target with either just water, a potion with no effects (i.e. Awkward Potion), or a potion with an effect already existing in the target potion.

https://streamable.com/5pxomu

This allows duplicating extremely complicated potions for free (with water), or with very basic ingredients like a single Nether Wart.

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

Discord Username

seoy

@SeooY SeooY added the Bug Modpack specific bug. label Nov 1, 2023
@MuteTiefling
Copy link
Contributor

I'm inclined to let this stay for a few reasons:

  1. Fixing it would mean a heavy nerf to most people's power generation capabilities
  2. Setting it up to dupe is arguably as much or more effort than just creating the potions normally.
  3. Ultimately, you're just saving on some easily farmed plants since all potions have been given easy farmable ingredients.

It does feel weird, however, that non effect potions can be melded at all. So I'll relay that to Ars Nouveau, at least.

@MuteTiefling
Copy link
Contributor

MuteTiefling commented Nov 6, 2023

Relayed: https://discord.com/channels/743298050222587978/1171186670813589564

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@MuteTiefling MuteTiefling added Mod Issue Bug within a mod. Status: Reported Mod issue has been reported. labels Nov 6, 2023
@SeooY
Copy link
Author

SeooY commented Nov 6, 2023

I agree, I don't think the Potion Melder output should be reduced to default. From my point of view it ideally should be fixed directly in Ars Nouveau, as the mod itself provides the option to increase the Melder output in the config, which causes this issue when the input potions aren't validated.

If it was me I would also check that the input potions don't have duplicated effects (so you can't just keep adding the same potion over and over), to balance it further, but I understand that check is more complex and removing non-effect potions will already alleviate most of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Modpack specific bug. Mod Issue Bug within a mod. Status: Reported Mod issue has been reported.
Projects
None yet
Development

No branches or pull requests

2 participants