Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing World Generation Info for certain ores / Ores not showing in JEI #677

Closed
pazi146 opened this issue Aug 29, 2023 · 5 comments
Closed
Labels

Comments

@pazi146
Copy link

pazi146 commented Aug 29, 2023

Modpack Version

1.12.1

Describe your issue.

The following ores don't have worldgen information listed in JEI (rightclick on ore):

  • Ancient Debris
  • Gold Ore
  • Copper Ore
  • Iron Ore

Additionally certain ores list the information but don't show up in JEI:

  • Coal Ore
  • Redstone Ore
  • Nether Quartz Ore
  • Bitumen Ore

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

Discord Username

No response

@pazi146 pazi146 added the Bug Modpack specific bug. label Aug 29, 2023
@NielsPilgaard
Copy link
Contributor

Thanks for the report!

@Kanzaji could you have a look at this please? 😃

@Kanzaji
Copy link
Contributor

Kanzaji commented Aug 29, 2023

Okay so, Ancient Debris isn't generated iirc from EE, so that is why it doesn't contain EE Generation info 😅

However for the other stuff.... ym... I have no idea what happened >.> I am fairly sure it worked back when we had JEI, and I didn't touch EMI yet at all 😅

Will try to experiment with this tomorrow, it might be either incompatibilities or some broken script, but I have zero idea at this moment >.>

@Kanzaji
Copy link
Contributor

Kanzaji commented Aug 29, 2023

Okay so from what I can tell, here is some statistics for tomorrow's debuggin session 😄

Missing Ore in EMI

  • Coal Ore
  • Lapis Ore
  • Nether Quartz Ore
  • Redstone Ore
  • EE Bitumen ore (Sand still shows up)

Missing information

  • Copper
  • Dimensional Geode
  • Fluorite geode
  • Sulfur Geode
  • Gold
  • Iron

Update on the issue

Edit 1

I found out the cause of msising ores in EMI, some ores weren't overriden in priority overrides for AlmostUnified, what caused it to prioritize Minecraft ores, what in the end caused any to show up for some reason. I added overrides to the config file and it works fine, however still no diea about missing information >.>

@Kanzaji
Copy link
Contributor

Kanzaji commented Aug 30, 2023

Okay so update time!

  • Mising ores from EMI were fixed, they show up now correctly and world gen information for them works \o/
  • Missing information for geodes will not be fixed for now 😢 The feature is not yet implemented in EE, so this will have to wait for Rid to have some time to work on EE 😅
  • Mising information for Copper/Gold/Iron is going to be fixed with the removal of EE Vanilla ingots/nuggets/blocks and raw materials, however this is impossible to do currently until a crash when crushed ore is present without an ingot is fixed, however the patch is made and I'm just waiting for Rid to look at it 😄
    The link to the PR: Fix a crash when Crushed ore processing type is present without ingot type. Ridanisaurus/EECreateAddon#4

Kanzaji added a commit to Kanzaji/Enigmatica9 that referenced this issue Aug 30, 2023
@Kanzaji
Copy link
Contributor

Kanzaji commented Oct 24, 2023

Update!
Rid has merged mine PR with the Crash fix, so I'm going back to work on this issue and removal of Vanilla Ingot replacements!
(What means I think I did everything back in August and just need to make sure and do a PR 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants