Add x_get_lock, synchronized changes #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function works in coordination with sychronized(), to provide a more flexible solution when coordinating between main thread tasks and custom thread tasks. When using sychronized() on the main thread, this is very dangerous, and can very easily lead to deadlocks when using x_run_on_main_thread_now within the secondary thread, which is a common pattern. x_get_lock provides an automated mechanism to help balance these concerns, and automates return of control to the main thread, and a backoff, so that deadlocks become far easier to avoid. This works in conjunction with the same lock pool as synchronized(), but it is changed to use a ReentrantLock object, rather than the native java synchronized() operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a new function, x_get_lock, which provides an asynchronous lock waiting mechanism. This uses the same underlying lock structure as synchronized(). Additionally, the lock object has now been restricted to non-value types, except strings. This is a breaking change, but is unlikely to affect anyone.