-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve package structure, refactor Manage Symptoms Screen #204
Merged
EmmaTellblom
merged 17 commits into
EmmaTellblom:main
from
carstenhag:feature/move-packages-refactor-manage-symptoms
Jan 30, 2025
Merged
Improve package structure, refactor Manage Symptoms Screen #204
EmmaTellblom
merged 17 commits into
EmmaTellblom:main
from
carstenhag:feature/move-packages-refactor-manage-symptoms
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstenhag
force-pushed
the
feature/move-packages-refactor-manage-symptoms
branch
from
January 26, 2025 20:48
04a989d
to
a311e89
Compare
…g, closing the db results in crashes
…s://github.com/carstenhag/Mensinator into feature/move-packages-refactor-manage-symptoms
carstenhag
changed the title
Improve package structure, refactor manage symptoms screen
Improve package structure, refactor Manage Symptoms Screen
Jan 30, 2025
EmmaTellblom
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring includes many bugfixes relating to the Manage Symptoms screen:
Important changes:
PeriodDataBaseHelper
no longer callsdb.close
. AtManageSymptomsViewModel
I introducedwithContext(Dispatchers.IO) {
, which performs the DB calls in the background. Multiple DB calls at the same time are fine. But not, when one has completed and callsdb.close()
while the other is still interacting with the DB.Minor fix: Display cutout insets at Settings screen, insets fixes at MensinatorApp