Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package structure, refactor Manage Symptoms Screen #204

Conversation

carstenhag
Copy link
Collaborator

@carstenhag carstenhag commented Dec 1, 2024

This refactoring includes many bugfixes relating to the Manage Symptoms screen:

  • When symptoms were getting create + colors were changed, the color values were not saved to the correct symptoms. It was just overall buggy.
  • Symptom creation now requires the user to type in a symptom name. A blank name is not valid anymore

Important changes:

  • Package structure of the app was changed
  • PeriodDataBaseHelper no longer calls db.close. At ManageSymptomsViewModel I introduced withContext(Dispatchers.IO) {, which performs the DB calls in the background. Multiple DB calls at the same time are fine. But not, when one has completed and calls db.close() while the other is still interacting with the DB.

Minor fix: Display cutout insets at Settings screen, insets fixes at MensinatorApp

@carstenhag carstenhag force-pushed the feature/move-packages-refactor-manage-symptoms branch from 04a989d to a311e89 Compare January 26, 2025 20:48
@carstenhag carstenhag changed the title Improve package structure, refactor manage symptoms screen Improve package structure, refactor Manage Symptoms Screen Jan 30, 2025
@carstenhag carstenhag marked this pull request as ready for review January 30, 2025 11:50
@EmmaTellblom EmmaTellblom merged commit e096295 into EmmaTellblom:main Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants